Simone Rubino
Simone Rubino
I'm starting to work on the `account_fiscal_year` migration, I'll try to follow the guidelines given in https://github.com/OCA/account-financial-tools/issues/1069#issuecomment-706683943 and will create a PR as soon as I've got something working
account_fiscal_year: https://github.com/OCA/account-financial-tools/pull/1081
@OCA/accounting-maintainers can someone update the issue's description? Thanks!
I'll try to solve and, hopefully, create a PR for fixing this in the next few (working) days; I just created this issue as a reference.
I see from https://github.com/OCA/account-financial-reporting/pull/660#issuecomment-621273250 that the PR won't be merged in `12.0`. So even if that solves this issue (still waiting for runbot), I don't see how that can help...
I actually share the same concerns as https://github.com/OCA/account-financial-reporting/pull/660#issuecomment-620492850 so I agree with not merging the PR because those changes would break a lot of other modules. Change is good, refactoring...
We'll see when the PR is done but I think the best way to proceed would be that when one of the 2 PRs is merged, the other one should...
> The script is not correct indeed. Part should be handled in OpenUpgrade `account` pre-migration, renaming the column to the definitive name. With enterprise, you should need to rename the...
> Might it be related to [OCA/purchase-workflow#834](https://github.com/OCA/purchase-workflow/issues/834) and my comment in #733 ? It might be, I didn't know purchase's version of triple discount but looks like every module is...
@OCA/accounting-maintainers can this be merged? @legalsylvain can you update your review? Thanks!