Samuel Hawksby-Robinson

Results 37 issues of Samuel Hawksby-Robinson

We should increase the coverage of the newly created clojure integration tests. One of the most common use cases is to send a message in a 1:1 or public chat....

bounty
feature
E:TechDebt
S:2

We should increase the coverage of the newly created clojure integration tests. One of the most common use cases is to join a public chat. The test steps that should...

bounty
feature
E:TechDebt
S:2

https://github.com/409H/EtherAddressLookup/pull/140#discussion_r147521302 >Made this amendment to allow the user to know which explorers will allow them the ability view ENS addresses. We can in future add new functionality to lookup the...

enhancement
address-related

- [x] ~Implement native JS popover functionality~ - [x] ~Implement native JS tab functionality~ - [x] ~Add popover styling~ - [x] ~Add tab styling~ - [ ] Add popover trigger...

enhancement

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace ```js this.replaceMethods = [ 'EtherAddressMethodReplace', 'OtherReplaceMethod', 'YetAnotherReplaceMethod' ]; ``` ```js generateReplacementContent(content) { for(var i=0; i < this.regExPatterns.length; i++){ content = content.replace(this.regExPatterns[i], function(match, p1, p2, p3){this[this.replaceMethods[i]](match, p1, p2, p3)}); }...

enhancement

With reference to issue #144 Applying tests to https://github.com/409H/EtherAddressLookup/blob/master/js/DomManipulator.js Particularly the changes that will be merged in with pull request https://github.com/409H/EtherAddressLookup/pull/140 Perhaps we can add a milestone to keep track...

enhancement
unit-test

Possibly using [Mocha](https://mochajs.org/) and [Chai](http://chaijs.com/). This is a big issue I know, but if we maybe take one js file at a time it'll break up the work load into...

enhancement
unit-test

- [x] #2601 - [x] #2626 - [x] #2653 - [x] #2656 - [x] #2729 - [x] #2790 - [ ] #2806

## What's Changed? I've added `httptest.NewServer` to serve test assets to the test. ## Why make the change? Because I ran this test the other day and it failed because...

## What's Changed? This PR adds new `StickerPacksStoreHandler`s for settings that are synced. In this PR I've introduced 2 types: - `OverwriteStoreHandler`, general setting update - `StickerPacksStoreHandler`, specific sticker pack...