Samuel Hawksby-Robinson

Results 48 comments of Samuel Hawksby-Robinson

@409H How do you expect this functionality to work? Create functionality so that automates the import of the lists from mew/metamask repos into this repo? Or reference the git repos...

I'm trying to get Mocha / Node to stop complaining about the chrome object to get unit testing functioning. We may need to rewrite the EtherAddressLookup constructor to take the...

Node says chrome doesn't exist, but that's because node is server side and we need to either run a headless browser on the server or mock the browser object or...

Analysis from @andremedeiro shows that fail is here https://github.com/status-im/status-go/blob/develop/peers/peerpool_test.go#L513 Error log ```text [2020-06-18T07:40:31.467Z] === RUN TestPeerPoolSimulationSuite [2020-06-18T07:40:31.467Z] === RUN TestPeerPoolSimulationSuite/TestMailServerPeersDiscovery [2020-06-18T07:40:31.467Z] --- FAIL: TestPeerPoolSimulationSuite (1.07s) [2020-06-18T07:40:31.467Z] --- FAIL: TestPeerPoolSimulationSuite/TestMailServerPeersDiscovery (1.06s)...

Hey @michaelsbradleyjr the filename of your migration should have the `*.up.sql` suffix otherwise it won't be picked up by the migrator. There are also a helpful make commands that will...

Hey @michaelsbradleyjr that's interesting. Are you able to see that the new indexes are created? I can see that `make generate` picks up the migration file to create a comm,...

>So I should change the name of 1628280060_create-usermessages-index.sql to 1628280060_create-usermessages-index.up.sql and 1631129360_fix-deletedmessages-index.sql to 1631129360_fix-deletedmessages-index.up.sql, and that's it? Yes, that should be enough for the migrator to pick up the new...

@PascalPrecht yes here is the manual https://notes.status.im/4VbZ0PlKR0GBE4d_A-qG_A All the actual work is already in place see the merged PR list under the "Prerequisites" section of this PR's description. If you...

Thanks @churik, I don't see a problem with merging this PR. @OmarBasem are you able to merge this PR? If not I am able to merge this for you.

For out bound Best to use RPC call [eth_getTransactionReceipt](https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_gettransactionreceipt) Example call: ```bash curl -X POST --data '{"jsonrpc":"2.0","method":"eth_getTransactionReceipt","params":["0xb903239f8543d04b5dc1ba6579132b143087c68db1b2168786408fcbce568238"],"id":1}' https://nodeaddress.eth:8585 ``` For a failed transaction `status` field will be `0x0`, see example...