Stephan Spengler
Stephan Spengler
Looking through #17343 again, there seems to be no change in the behavior for flat surfaces. I'll investigate further.
> > Looking through #17343 again, there seems to be no change in the behavior for flat surfaces. I'll investigate further. > > Its the change to the `SceneryQuadrantOffsets` i...
Why? Especially, how would you justify (i.e. by a comment in `SmallSceneryPlaceAction`) why we add one to the offset? I argue that `SceneryQuadrantOffsets` now contains the values how they should...
> Just make the two line change to Paint.SmallScenery.cpp L161-162 adding a +1 to each. I think this is the way to go. But add a comment about where the...
> I am not sure why this would be a bug. I think internal code has the same restriction. The code should set the min/max if it wants to change...
In particular, the min/max values are optional when creating a window, but are still internally set to the width/height value. This is not transparent at all.
When I created the issue and the PR, I only thought about custom windows and did not realize that it would also effect vanilla windows. So I have to overthink....
> For plug-in developers this can be really confusing, since they don't set a minimal or maximum size anywhere. Wouldn't it be better to simply set the min to zero...
I added documentation to `Window` and `WindowDesc`. Let me know what you think. I also increased the api version.
We should really update the .d.ts to include the action args types for all actions.