Stefan Profanter
Stefan Profanter
The problem is that I can't change the class which is serialized, thus I can't change `__getstate__` (the code is generated by a 3rd party script, namely genpy from ROS)...
Thanks for the feedback. Here some comments: 1. I would suggest adding a boolean to `OpcUaServerConfig` to enable/disable the new discovery services. Good to go? 2. What would be the...
> With an LDS the options get more complicated. I think we should keep it very simple: The developer can/should decide (with the boolean config variable) if the current server...
I already merged master, see https://github.com/eclipse/milo/pull/89/commits/8eb1926f26d189cddea04b65771ac457e3a32c81 I'm currently implementing the stuff we discussed, and will also try to add examples and unit tests.
@kevinherron may I ask why you need to rewrite history? That's really bad practice and will break not only my branch but all the other forks. So there should be...
@kevinherron I now implemented Examples for the discovery and cleaned up the code. Can you review it and tell me if there are any changes required? Unfortunately I didn't find...
Done as requested :+1:
I don't mind if you change things directly here in this PR (you can push to it). Otherwise, maybe end of next week I'll have some time to address your...
Just as an additional note: I already tested this Milo LDS implementation in combination with the one I wrote for open62451 and they were able to talk to each other,...
@kevinherron I changed the things you mentioned in your review