Stefan Profanter
Stefan Profanter
@kevinherron I now also added unit tests for discovery. Is there anything else I can improve?
I rebased this PR onto dev/0.2.x The current error in travis is due to the fact that the identity checking test actually never worked before. The KeyStoreLoader always initialized the...
Maybe it's best if you just commit the changes into this PR's branch, so everything is kept together. See https://help.github.com/articles/committing-changes-to-a-pull-request-branch-created-from-a-fork/ And then merge it. That's probably better for later reference.
I changed the MdnsHelper to not start its own thread, as you suggested. Fortunately it was quite easy. I'm not sure why I added this additional thread in the first...
Your changes look good! I also like it better that way. Currently I'm not working on this branch/PR so feel free to push/force push if needed.
@kevinherron any update on this PR?
Thanks for reporting this! Can you propose a PR with your changes?
@Infinity95 do you have an estimate when #2408 will approx be ready to be merged?
you can propose a PR on the master branch. I guess #2408 will take some more time. Later on we can integrate/rebase #2408 onto your changes.
@mitza-oci just a short question: What is the status about DDS-PSM-Cxx support in OpenDDS?