Olly
Olly
@jonathonherbert Has expressed interest in pairing with us on this one!
> I raised PR https://github.com/guardian/frontend/pull/25400 as a propsal This is great thankyou! I'd actually originally created the file as .ts but didn't manage to figure out there were TS variants...
@HarryFischer Do you have any thoughts on this?
Picking this up to try and figure it out!
I believe the start of the issue could stem from here: https://github.com/guardian/frontend/blob/main/facia/app/controllers/FaciaController.scala#L194 This logic says that if there are no collections in the 'ad free' variant of a front (which...
This would require a lot of refactoring in DCR:
TODO: Mobile Ads
> This container is, by a fair margin, the most complicated of them all dynamic/fast is still to come! 😫😫😫 Thank you for the feedback though - implementing a lot...
Okay it's not _actually_ one line ... The code for the 'no timezone' is added here: https://github.com/guardian/frontend/pull/24848/files In DCR we can switch from using `blockFirstPublishedDisplayNoTimezone` to `blockFirstPublishedDisplay` (and remove the...
@jamesgorrie to follow up