dotcom-rendering icon indicating copy to clipboard operation
dotcom-rendering copied to clipboard

Timezones On Liveblog Blocks

Open JamieB-gu opened this issue 3 years ago • 1 comments

At the top of each liveblog block there's an absolute timestamp corresponding to when the block was published. This timestamp doesn't currently include a timezone.

As a result, it could be unclear to users which timezone this timestamp is in, particularly those who are currently outside of one of the three timezones we support (Europe/London, America/New_York, Australia/Sydney).

We should add a timezone alongside the timestamp. We already do this for the "updated" timestamps that appear at the bottom of some liveblog blocks.

JamieB-gu avatar Aug 11 '22 13:08 JamieB-gu

FYI @paperboyo @blishen

JamieB-gu avatar Aug 11 '22 13:08 JamieB-gu

@OllysCoding says: "This is just a one line change in Frontend"

oliverlloyd avatar Aug 25 '22 09:08 oliverlloyd

Okay it's not actually one line ... The code for the 'no timezone' is added here: https://github.com/guardian/frontend/pull/24848/files

In DCR we can switch from using blockFirstPublishedDisplayNoTimezone to blockFirstPublishedDisplay (and remove the former from the schema) - then revert the frontend PR to remove the code.

Image

OllysCoding avatar Aug 25 '22 10:08 OllysCoding

Okay it's not actually one line

I knew it!

Thanks for the extra detail 👍

oliverlloyd avatar Aug 25 '22 10:08 oliverlloyd

FYI this change will happen in AR as part of a wider overhaul to datetimes to make them more similar to dotcom: #5688

JamieB-gu avatar Aug 25 '22 14:08 JamieB-gu