Nitesh Kant
Nitesh Kant
In order to avoid impact from changing transitive dependencies, it is preferred to explicitly depend on the modules which are directly used in code. Examples build files do not seem...
`HttpClientBuilder#appendConnectionFactoryFilter()` has the following signature [1]: ```java public abstract HttpClientBuilder appendConnectionFactoryFilter( ConnectionFactoryFilter factory); ``` This means that a `ConnectionFactoryFilter` implementation if using the connection to make a request (or other...
Originating discussion: https://github.com/servicetalk/servicetalk/pull/261#discussion_r250881023 Since, `retryFor` predicate requires `HttpRequestMetadata` and we use this predicate in the response path, we retain this object longer than otherwise (request will be eligible for GC...
PR #186 added `collect()` methods for `Single`. These methods internally use `Publisher#flatMapSingle()` and hence does not guarantee order in the generated `Collection` (returned by `collect()`). As we do not have...
We pick individual components from `GlobalExecutionContext` when users decide to override part of the `ExecutionContext` from client/server builders. Since `GlobalExecutionContext` is a singleton, it will create the `IoExecutor` and `Executor`...
`releaseAsync()` is advertised as idempotent but we do not allow subscribing twice to it. In order to simplify user control flow, we should make `releaseAsync()` idempotent just like `closeAsync()`. Otherwise...
We use a global DNS `ServiceDiscoverer` for clients when no `ServiceDiscoverer` is provided by the user. This DNS `ServiceDiscoverer` uses `DefaultDnsServiceDiscoverer` which requires closing, failing which leaks a channel. EDIT:...
HTTP APIs follow the convention: - For aggregated APIs (non-streaming): No qualification is present in the names. eg: `HttpRequest`, `HttpResponse`. - For async streaming APIs: We prefix with `Streaming`. eg:...
There have been some discussions in #565 and #561 around upgrading RxJava to 2.x in RxNetty. I would like to spin that into the following: _Make RxNetty stick to exposing...
Compression/decompression of HTTP request/responses is a pretty common requirement for HTTP client and servers. It is somewhat complex to use the netty's stock `HttpContentCompressor` and `HttpContentDecompressor` with `RxNetty` because of...