Nitesh Kant

Results 117 comments of Nitesh Kant

As a side-note: This is also true for request-channel interaction model on either side (request/response) I am not sure though whether a ReactiveSocket implementation SHOULD implement this check. At least...

@yschimke yes, it would result in more data being received by a peer but that isn't really avoidable if we assume rogue peers, eg: Even if a stream is cancelled,...

I am on the fence for defaulting to a lower data size than frame size (currently max of ~2GB) for this reason as it would also be a function of...

@tmontgomery agreed, however, as I understand this is around per stream flow control (byte-level) as what HTTP/2 specifies with WINDOW_UPDATE and not for the entire connection as what TCP provides...

@benjchristensen from what you are describing, it sounds to me more a case for stream priorities as opposed to byte-level flow control. Let us take the case you describe: ```...

Thanks @guaporocco for the suggestion. We are definitely interested in knowing how ServiceTalk fares as compared to other libraries but the work is low on our priority list and realistically...

FYI There is a PR for the benchmark (not by ServiceTalk team) here: https://github.com/TechEmpower/FrameworkBenchmarks/pull/5270

@arthur-techempower @nbrady-techempower I would need some time to get legal approval to comment on your PR https://github.com/TechEmpower/FrameworkBenchmarks/pull/5270 but I would suggest going through this document on ServiceTalk performance: https://apple.github.io/servicetalk/servicetalk/SNAPSHOT/performance.html Specifically,...

Originating discussion: https://github.com/servicetalk/servicetalk/pull/283#discussion_r253653085

Another failure: https://ci.servicetalk.io/job/servicetalk-snapshot/630/testReport/io.servicetalk.http.netty/ClientClosureRaceTest/testPipelinedPosts/ ```java io.servicetalk.http.netty.ClientClosureRaceTest.testPipelinedPosts Error Message java.util.concurrent.ExecutionException: io.netty.channel.socket.ChannelOutputShutdownException: Channel output shutdown Stacktrace java.util.concurrent.ExecutionException: io.netty.channel.socket.ChannelOutputShutdownException: Channel output shutdown at io.servicetalk.concurrent.api.SourceToFuture.reportGet(SourceToFuture.java:121) at io.servicetalk.concurrent.api.SourceToFuture.get(SourceToFuture.java:92) at io.servicetalk.http.netty.ClientClosureRaceTest.runIterations(ClientClosureRaceTest.java:148) at io.servicetalk.http.netty.ClientClosureRaceTest.testPipelinedPosts(ClientClosureRaceTest.java:137) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at...