Nayef Ahmed

Results 53 comments of Nayef Ahmed

Disabled tests again due to URL breakage https://github.com/pytorch/text/pull/920. To answer your question @AngledLuffa, we are using mock zip files for our tests, however, the filename is found by getting the...

@xhluca this seems like a reasonable request. Do you want to take a stab at implementing this and I can provide a review?

> @Nayef211 @malfet Are you familiar with loongarch? I guess this PR is safe as long as the basic double-conversion functionalities are tested on upstream. I'm not, but the changes...

cc @ejguan and @VitalyFedyunin as this seems to be an issue with the CacheHolder datapipe from torchdata

@arnavmehta7 thanks for creating this! Can you please fix the [linter issues](https://app.circleci.com/pipelines/github/pytorch/text/6752/workflows/6d68e250-d994-490d-bc96-f5fd360f4a81/jobs/233009) that show up on CI before we merge the PR?

> How can I fix these MacOS build issues? This was fixed by https://github.com/pytorch/text/pull/1889 and should be fixed in your PR once you rebase on the latest main branch.

> Still MacOS errors? Can you point out my mistake, I'm extremely sorry if I have done something wrong > > EDIT: Still 3 errors :( @arnavmehta7 the current failures...

@acxz I think this might have been an oversight when the dataset was implemented. To be consistent with our other text classification dataset, we do want to return labels as...

@acxz lmk if you still plan on taking this on, otherwise I'm happy to submit a PR for it this week 😄

> Is `iopath` fully available in OSS space? > > There was an attempt to do this in the past, but reverted due to #1380 It seems like `iopath` is...