text icon indicating copy to clipboard operation
text copied to clipboard

Add repository double-conversion support for loongarch

Open nmanhong opened this issue 3 years ago • 4 comments

Add warehouse double-conversion to support loongarch, which has been tested on loongarch and can be passed

nmanhong avatar Sep 20 '22 03:09 nmanhong

Hi @nmanhong!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Sep 20 '22 03:09 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Sep 20 '22 04:09 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Sep 20 '22 04:09 facebook-github-bot

@Nayef211 @malfet Are you familiar with loongarch? I guess this PR is safe as long as the basic double-conversion functionalities are tested on upstream.

I'm not, but the changes aren't breaking any new CI tests. I'm okay with merging it unless you think we should get eyes from someone that's more familiar with loongarch

Nayef211 avatar Sep 20 '22 19:09 Nayef211