Dmitry Sidorov
Dmitry Sidorov
I'm not so sure, that buffer_location property is allowed on buffers. If my understanding is correct, it only allowed on accessors and on malloc_ functions. @romanovvlad @dm-vodopyanov could you please...
tagging @sergey-semenov
At this point code suggestions were applied, changing API names are up to specification folks.
Thanks for the suggestions! I'll apply them a bit later. For now I answer the most important one, that affects the actual implementation.
Resolved comments with a simple fix, answered others.
> @MrSidims any plans finishing this PR? I was thinking, that everything is in place. Let me double check/resolve comments.
@mmerecki @bashbaug hi, do you know, what is the status here?
> But SPIR-V Tools do not emit any errors for this SPIR-V file. The report says, that generated SPIR-V is not conformant to https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Env.html . SPIR-V Tools only checks conformance...
It's a first part of https://github.com/intel/llvm/pull/13316
@intel/dpcpp-cfe-reviewers please take a look