llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL] Combine checks of buffer properties for buffer creation

Open maximdimakov opened this issue 3 years ago • 3 comments

There is mem_channel property for buffer that is not checked when buffer is allocating. This patch combines checks of needed properties for buffer allocation.

The spec can be found here: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/supported/sycl_ext_intel_mem_channel_property.asciidoc

Signed-off-by: mdimakov [email protected]

maximdimakov avatar Mar 25 '22 12:03 maximdimakov

@MrSidims could you please review?

maximdimakov avatar Apr 04 '22 18:04 maximdimakov

I'm not so sure, that buffer_location property is allowed on buffers. If my understanding is correct, it only allowed on accessors and on malloc_ functions.

@romanovvlad @dm-vodopyanov could you please find a new owner for this PR?

MrSidims avatar Sep 21 '22 12:09 MrSidims

tagging @sergey-semenov

MrSidims avatar Sep 21 '22 13:09 MrSidims