Maxim Moinat

getElementsByTagName() does not return array

1

If you try to get all the anchors like this, then by default one (the last) element is returned: `$anchors = $soup->getElementsByTagName('a');` The following does give me all the elements:...

The Concept level thresholds file for v5.2.2 has several bugs. - the first three should be 'VISIT_OCCURRENCE,VISIT_CONCEPT_ID', not condition. - there is an inconsistency between using CONDITION vs CONDITION_OCCURRENCE as...

`tablesToExclude` disables checks on fields in non-excluded tables

1

# Expected behaviour When specifying `tablesToExclude`, only the checks on the specified tables are disabled. # Observed behaviour When specifying `tablesToExclude`, it also disables checks on fields with a foreign...

Adds `pathToDriver` and `numThreads` arguments

Domain and Class checks denominator only non-zero concepts

3

Fixes #309 The idea is that this change will give a more meaningful fail%. However, it might be confusing that the denominator count is different in the same table for...

Table level Measure Concept Completeness

2

I stumbled across the Table level MEASURE_CONCEPT_COMPLETENESS check, which I haven't seen before. I could only find the sql file, but is not described anywhere else afaik. Is this check...

Apply new thresholds without re-executing DQD

3

Currently, you have to run the whole DQD execution again after updating the thresholds to apply them. Like this: ```mermaid graph LR A[Execute DQD on CDM] --> B[Inspect Resultsin Shiny...

Hemoglobin [Mass/Volume] gram / dL plausibleValueLow

2

There is a minor inconsistency in the `plausibleValueLow` of the "Hemoglobin [Mass/volume] in Blood" (3000963). For some reason this is set to 0 for all units except "gram per deciliter",...

isTemporallyConstant and validPrevalence thresholds without check description

3

Looking at the [Concept_Level threshold file](https://github.com/OHDSI/DataQualityDashboard/blob/main/inst/csv/OMOP_CDMv5.4_Concept_Level.csv), I noticed that there are two checks that are not part of the check descriptions: `isTemporallyConstant` and `validPrevalence`. From searching in previous threads (#46),...

New way to edit thresholds

2

Adds function `editThresholds(threshold_file)` that can create a thresholds file from a table of modified thresholds. As described under point 1 in this OHDSI 2021 collaborator showcase: https://www.ohdsi.org/2021-global-symposium-showcase-67/ Making it a...