Maxim Moinat

Results 61 comments of Maxim Moinat

The documentation says: > Examples: python gcexport.py --count all will download all of your data to a dated directory. Does this work for you?

In general, to check consistency, it would be nice to convert units where possible and check if low and high values are consistent for each measurement. Not a trivial check...

That is awesome, thanks Clair. So the magic seems to be in the [`.evaluateThresholds` function](https://github.com/OHDSI/DataQualityDashboard/blob/edd8125ad8496fc9ba407cc7a44a473a57ac5767/R/execution.R#L456)... Will give it a try for my use case and see if we can turn...

I see your point and happy to discuss. However, I not join the meeting as I am on holiday. But I can join in two weeks to discuss! @clairblacketer

Closing to keep check as is. This will keep things simpler to explain: the %fail will represent the % of records in the table with a wrong domain, among all...

Also, it would be nice if the new shiny dashboard would be integrated into the package. Now, I have to run the shiny app from the `ui.R`. Ideally, there will...

Thanks @clairblacketer for the pointers, I was able to launch the new shiny app as well with those changes. I will do some further testing coming week. @dmitryilyn @laacdm In...

@dmitryilyn Yes, these are not relevant for this PR anymore. I have marked my (and Clair's) comments as outdated. Thanks for adding the new flags documentation!

We also need to reflect the changes in the sample code and documentation. - [ ] Update [codeToRun.R](https://github.com/OHDSI/DataQualityDashboard/blob/e5c3300f50bf0925d2526302ab230b89f7bbbb4c/extras/codeToRun.R) with the new parameters `writeToCsv` and `csvFile`. - [ ] Add the...

@dmitryilyn Any progress on this? Would love to use this new feature in an upcoming data quality analysis. Maybe I can help out with the implementation if you are tight...