Matthew Leslie
Matthew Leslie
Hello @BrennanConroy, I've reopened the PR and pushed some new commits. **I'm encountering a couple of challenges that I'm currently addressing:** 1) For the `ServerSentEventsTransport.cs` call site, the test hangs...
Thank you very much for the insight @BrennanConroy. I believe I have completed all the necessary tests.
@BrennanConroy, it seems functional tests from MVC are failing due to `httpClient.timeout`. Can I assume this is network related ?
@MackinnonBuck, may I please request a review on this.
@SteveSandersonMS Thank you for the review! Really appreciate the detail. At first glance the feedback is making sense, I'll need a bit of time to make the changes.
@RidaEn-nasry are you currently working on this ?
Hey @captainsafia. Would passing the environment name be sufficient here or would it be worth looking into support other environment variables too?