aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard
verified publisher icon dotnet

Enable input number component to support type='range' attribute

Open MattyLeslie opened this issue 1 year ago • 1 comments

Enable input number component to support type='range' attribute

Summary of the changes

  1. Modified the InputNumber component to allow the 'type' attribute specified by the user to take precedence over the default 'type="number"'. By swapping the order in which attributes are added to the builder, any user-defined 'type' attribute is now respected, enabling the usage of different input types like 'range'.

  2. Added a unit test to InputNumberTests to ensure the user defined type attribute overrides the default

Fixes #52067 by ensuring the type of the InputNumber component can be specified.

MattyLeslie avatar May 07 '24 13:05 MattyLeslie

Thanks for your PR, @MattyLeslie. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

dotnet-policy-service[bot] avatar May 07 '24 13:05 dotnet-policy-service[bot]

Commenter does not have sufficient privileges for PR 55583 in repo dotnet/aspnetcore

azure-pipelines[bot] avatar May 28 '24 06:05 azure-pipelines[bot]

/azp run aspnetcore-ci

javiercn avatar May 28 '24 09:05 javiercn

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 28 '24 09:05 azure-pipelines[bot]

@MackinnonBuck, may I please request a review on this.

MattyLeslie avatar Jul 08 '24 08:07 MattyLeslie