Matthew Mitchell

Fix CSizeComputer and remove witness size constants

2

The `size` and `vsize` of transactions, and the `size` and `strippedsize` of blocks are displayed identically even with witness transactions. When `PROTOCOL_VERSION | SERIALIZE_TRANSACTION_NO_WITNESS` is passed to `GetSerializeSize`, it has...

`MAX_FEE_ESTIMATION_TIP_AGE` is unused in validation.cpp. This and any other unused constants should be removed.

In the receive tab, there are options for "Base58 (Legacy)", "Base58 (P2SH-SegWit)" and "Bech32 (SegWit)". The `P2SH_SEGWIT` outputs are not used by the client minting code. Therefore they should be...

Formatting of Generated Code is Ugly

4

### Describe the bug When generating code using 2.0.0-dev.28, the output of `rust_ffi.g.dart` is ugly with weird indentation. A example snippet: ```dart @freezed class CustomError with _$CustomError implements FrbException {...

Remove Ambiguity of Script ASM Hex and Decimal Integer Representations

11

### Please describe the feature you'd like to see added. Distinguish between decimal and hex integers in the script ASM to avoid ambiguity. Hex integers/data can be prefixed with `0x`...

I was thinking of doing `if (::GetSerializeSize(txNew, SER_NETWORK, PROTOCOL_VERSION) > 1000 && i > 0)` so that it will still continue if one output goes over the 1KB size and...

When using AES/GCM/PKCS7 the authentication tag is not included in the encrypted output. This is because `PaddedBlockCipherImpl` does not call `doFinal` of `GCMBlockCipher`. This means AES/GCM/PKCS7 is not authenticated and...

Compatibility with ROAST and the missing ShareVal algorithm

4

I've been assessing the potential use of this library for implementing the [ROAST scheme](https://eprint.iacr.org/2022/550) for coordinating signatures. In the ROAST paper, the ShareVal algorithm is required that can identity an...

To reproduce: 1. Create a new ROAST group and click "Consent & Create Group" 2. Add another participant 3. Click "Share Your Public Key" 4. Take screenshot of QR code...

ROAST: DKG acceptance doesn't always work

1

Occasionally, attempting to accept a DKG results in the following:  No particular error is shown in the logs. Note that the failed acceptance occurred between these two log entries:...