Matthew Mitchell
Matthew Mitchell
I started to get what appears to be the same issue causing disconnections overnight: ``` 2023-09-19 06:34:59,832 — api.py — ERROR — api_request:246 — TLSPinningHTTPSConnectionPool(host ='api.protonvpn.ch', port=443): Max retries exceeded...
In the dart library coinlib (https://pub.dev/packages/coinlib) I followed the same approach of encoding everything in HEX with integers encoded as LE. However -1 is encoded as -1. See the code...
I agree that `0d` is not a good idea, much better to go with `0x` for hex.
`0x` is much more standard and recognisable than `[]`.
> It's pretty misleading though, since `CScriptNum` is little-endian: if you see `0x0100` you would expect that to be 256, but for us it would actually be non-minimally-encoded 1; For...
> Provided you've already dealt with non-minimally encoded -1 and 1..16, using decimals seems nicer here? You can cope with negatives cleanly (`-2` vs ``), and it's one less encoding...
For 32-bit signed integers, the 32nd leftmost bit is negative, but that's not true for CLTV and CSV which uses 5 bytes. So a push data could represent a negative...
@sipa I'll have to look at the code. I imagine it is two's complement? Then the negative bit will be different for each type of integer meaning that a 4...
@sipa Sorry, you are right. I looked at the code again. Bitcoin doesn't use two's complement for this (I have to keep in mind that Bitcoin has a lot of...
Could we use `UNKNOWN_n` where n denotes the op code hex/decimal such as `UNKOWN_FE` for `0xfe`?