khaledto comments

Results 7 comments of


                                            khaledto

2.0

@sfermigier, can you explain how does it fix tests? To me it looks like you are commenting Test Suites, or is there something I'm missing? Anyways it's cool to see...

2.0

Ok makes sense, also I forgot you branched from 2.0. Thank you @sfermigier.

Fix test_explicit in test_aggregates

We also need to remove *raise NotImplementedError("Depreciated in this context")* https://github.com/DataBrewery/cubes/blob/140133e8c2e3f2ff60631cc3ebc9966d16c1655e/tests/common.py#L54 But before that I need to understand why this exception is raised there. Can someone explain me that?

Incomplete and broken unittests

Hi @Stiivi, I would like to work on this.

Natural ordering isn't working

Hi @anton-kaidalov, yeah there was already an issue on natural ordering. That's some great debugging info, thank you very much. Will have a look at this.

ImportError: No module named wsgi

Hi @xialeizhou I think in server.py ```python from gevent.wsgi import WSGIServer ``` has to be changed to: ```python from gevent.pywsgi import WSGIServer ```

clinicaltrials_download() function running into errors when argument "include_results" is set to true and "count" is greater than 10

I had the same error today when I ran `studies sessionInfo() R version 3.5.2 (2018-12-20) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 10 x64 (build 18362) Matrix products: default locale: [1]...