cubes icon indicating copy to clipboard operation
cubes copied to clipboard
verified publisher icon DataBrewery

Incomplete and broken unittests

Open Stiivi opened this issue 8 years ago • 5 comments

Unittests are incomplete and broken. They are in very bad shape. This is a large task to be done.

Tests to be reviewed:

  • [ ] Metadata
  • [ ] Cells
  • [ ] Workspace
  • [ ] Browser
  • [ ] SQL
  • [ ] Server

The list might be broken into several smaller issues and this issue might serve as a 'master issue'.

This is a good opportunity to learn about Cubes internals and give feedback about it's flaws. I am willing to assist to anyone who wants to take care of this issue.

Stiivi avatar Mar 11 '17 16:03 Stiivi

Hi @Stiivi, I would like to work on this.

KhaledTo avatar Mar 13 '17 04:03 KhaledTo

Thank you. Before we do anything with the test suite, I think it would be great if it was restructured to match the project modules (units).

What is your approach? How can I help you?

Btw. if you decide to do it, do it please in the 2.0 branch with Python 3.6.

Stiivi avatar Mar 13 '17 04:03 Stiivi

The #408 (Cube Query flow redesign) might have influence on rewriting unittests tests. It should be anticipated that the tests will change. Good news is, that after the redesign the tests are going to be way much cleaner and manageable.

Stiivi avatar Mar 14 '17 03:03 Stiivi

#407 (removal of Cube from cell) broke tests.

Stiivi avatar Mar 14 '17 17:03 Stiivi

Silenced broken unittests in #426 so that CI is passing for now – temporarily for #393, which is now priority.

Stiivi avatar Mar 29 '17 02:03 Stiivi