Ruslan Sayfutdinov

Results 133 comments of Ruslan Sayfutdinov

Yeah, I'd be great to have some tests for this new feature. And that `RustBinaryIntegrationTest` is very flaky, if you can fix it (in a separate PR), I'll really appreciate...

@Lcsmarcal is it still WIP?

Try these steps: https://github.com/facebook/buck/pull/2611#issuecomment-819784681

I don't think it's supported.

For some reason the CI is not triggered on your PRs. Maybe this is because of your email in commit not linked to your github account.

For some reason CircleCI jobs haven't been triggered. Can you try to push something to make them run?

@yanks can you please follow these steps to make CI jobs running? https://github.com/facebook/buck/pull/2611#issuecomment-819784681

Hi @SiddhantRanade! Thank you for your contribution but we need CI jobs to pass in order to merge this. Try to rebase and rerun them.

I think you can set default flavor instead of passing it as target flavor, this can done in invocation with `--config` option. Then genrule should also use it.