facebook
[apple] Add "umbrella" suffix to default umbrella header name
In our project we have some both internal and external dependencies in Obj-C with manually created "umbrella" files. They are interfere with BUCK generated "ModuleName.h" umbrella files. One example of such dependency is https://github.com/yapstudios/YapDatabase/blob/master/YapDatabase/YapDatabase.h
This PR will add ModuleName"-umbrella.h" suffix to avoid this issue. This behaviour will be similar to CocoaPods
Hi @alekseevpg!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
