Kallinteris Andreas
Kallinteris Andreas
that would be awesome
When we are making an Environment API, it should support all environments (other than perhaps very weird edge cases) so it should be: ## rng - `observation` & `reward`: `terminal`...
`observation` is not completely deterministic, in fact it is never deterministic in real world problems, real world sensors always have some noise with them
1. APIs should be designed to support all possible (or at least as many as possible environments) 2. Can you make a performance measurement of the impact of those extra...
Regarding the changes to the XML model files, I would like to see verification using the [check_environments_match()](https://github.com/Farama-Foundation/Gymnasium/blob/main/gymnasium/utils/env_match.py) function, for multiple `mujoco` versions (100k steps per version should be enough)
I would like the `xml_file` changes moved in their own separate PR, and validate them for all supported `mujoco` versions (`2.2.0` up to `2.3.7`)
In general it is best practice to have pull requests contain one type of change. And I'm sensitive to the changes to the XML model files as they can have...
@evangelos-ch at least validate the XML file changes for all supported `mujoco` versions as described in a previous comment
LGTM with regards to the XML file changes.
From my testing With my phone (aarch V8) the core api works fine, but not all environmnets May work since they rely on third party libraries (mujoco worked fine) Also...