Jason Young
Jason Young
If linting, type checking, and formatting are done as pre commit hooks, can we run precommit hooks in a GH action? Then there is a single place where these things...
> Nit: please squash into a _single_ commit. Can always squash and merge via GitHub
I am working with @poorejc on adding this feature. I started with @EandrewJones buildDatasets() function. I tested it, it worked, and then there was a discussion on what information we...
> @Jyyjy Did we not merge a PR that closes this ticket? We merged an example of how to use custom logging for attributes, but it is not in the...
There was no reason against adding it. I think there wasn't clear consensus on if the example is what everyone wanted in the core package
I'm going to delete the example code and move the functionality into packageLogs, if there are no objections. https://github.com/apache/flagon-useralejs/tree/master/example/log-attribute-example
https://github.com/apache/flagon-useralejs/commit/4eec2ffd87880bc96858f2802b054058eeebb003
> Hello @poorejc, I am facing some problems in understanding the project, Would you please help me to start? It would be great if we could have a direct conversation...
I don't see why this can't be done with the existing package log callbacks. The callbacks are passed the log and a copy of the event, so a user could...
This is a pretty large ticket. Make sure to test your changes with`npm test`. You will have to change how playwright, the extension testing framework, loads the extension here: https://github.com/apache/flagon-useralejs/blob/master/test/e2e/spec/fixtures/extension.fixture.ts...