apache
CI(gh actions): Improve GH action suite
Problem
Our GH action suite is sparse and only automates testing. We are leaving a lot of the table. We could be enforcing far more checks to save ourselves headaches during releases.
Solution
Add GH actions to enforce:
- [ ] linting
- [ ] type checking
- [ ] formatting
- [ ] skywalking-eyes for license compliance
- [ ] Automatic Release notes
- [ ] Cronjobs for automatically triggering new release candidates
NOTE: These probably should be broken into separate tickets.
If linting, type checking, and formatting are done as pre commit hooks, can we run precommit hooks in a GH action? Then there is a single place where these things are defined.
Well the config files are the single source of truth for both in this case. Husky is not like like python where it's referencing rules from external places. It's just running npm commands.
Best
Evan Jones Website: www.ea-jones.com
On Thu, May 9, 2024 at 1:37 PM Jason Young @.***> wrote:
If linting, type checking, and formatting are done as pre commit hooks, can we run precommit hooks in a GH action? Then there is a single place where these things are defined.
Relevant GH action https://github.com/pre-commit/action
— Reply to this email directly, view it on GitHub https://github.com/apache/flagon-useralejs/issues/448#issuecomment-2103122821, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2T6ANORBPRQKLXJPWYMO3ZBOX6ZAVCNFSM6AAAAABHLHVEDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGEZDEOBSGE . You are receiving this because you authored the thread.Message ID: @.***>
