Julia Jia
Julia Jia
@qiayuanl , IMO, ONNX runtime is largely transparent to the ROS2 Control Framework which defines standardized interfaces that controllers must implement, regardless of their internal implementation details. That said, there...
@MarcoMagriDev, please add tests covering this change or update existing tests. This helps with review and future maintenance.
@maciejmajek, happy to help with this! I'll start with unit tests and then look at the overall design and implementation. I'm going to start with synthetic data for unit tests,...
> I've noticed, that the filtering does not work well for other methods than isolation_forest, but I believe this is just a default param issue. Yeah, isolation_forest works better for...
> @Juliaj Apologies for no activity on our side for this PR. Would you find some time to resolve conflicts, so we can continue the review? @boczekbartek, thanks for helping...
Thank you, @sachinkum0009, for your interest in this! I think the core team uses `excalidraw` for diagrams. For this case, it would be simpler to update the original source file,...
> However, looking at the diff for commit [74a8f6c](https://github.com/ros-controls/ros2_control_demos/pull/982/commits/74a8f6cf5005fedc4dd7f2fb840cb28f095104bb), the merge commit also seems to have added other stuff that may be the cause for these failing tests. @philipchurchley, the...
> Yes, although I'm not sure what the failing jobs are for. Could it have to do with the missing EventHandlers? @philipchurchley, for the failed pre-commit jobs, run following commnd...
> @Juliaj How relevant are additional test cases for the inheriting controllers? Since I only added passthrough for the class variable in the controllers, tests for each inherited controller would...
> @Juliaj How relevant are additional test cases for the inheriting controllers? Since I only added passthrough for the class variable in the controllers, tests for each inherited controller would...