Jay Patel
Jay Patel
Will open a new one with proper guidelines @legalsylvain .
web_chatter_position #2833
web_select_all_companies #2834 Approved :+1:
sale_line_returned_qty : Migration to 17.0 #1614
hey @legalsylvain @chienandalu @CRogos i have closed the previous PR (#2826) and created this new one following every guideline , can you please review?
@Rad0van Oh ! its because of the optional chaining (https://github.com/OCA/web/pull/2833/commits/12b405bc65130ff15204bfb73c0f194f05182e27) if (child.attributes?.name?.value !== "button_box") { append(form, this.compileNode(child, params)); } I have fixed this and code is working as expected but...
@CRogos Merge/squash done . Also in this PR i have tested "when you click the very first time, it is not working" this issue is not there. Also it has...
@legalsylvain Please review.
> Hey! I am the guy from the other PR #2798. I have tested both our implementations on runboat and they are practically the same. Our solution looks very similar....
@legalsylvain @CRogos What is the next step to get this PR merged ?