web icon indicating copy to clipboard operation
web copied to clipboard

[17.0][MIG] web_select_all_companies: Migration to 17.0

Open Jp-alitec opened this issue 1 year ago • 12 comments

Migrated to V17

Jp-alitec avatar May 24 '24 07:05 Jp-alitec

here is also another PR: https://github.com/OCA/web/pull/2798

CRogos avatar May 24 '24 08:05 CRogos

@CRogos Merge/squash done .

Also in this PR i have tested "when you click the very first time, it is not working" this issue is not there. Also it has some additional style changes that differ from V16 (the font size , hover styles ).

also i think in the existing PR #2798 branches might not be get selected from this functionality whereas in this PR that issue is also fixed.

image

Jp-alitec avatar May 24 '24 11:05 Jp-alitec

@legalsylvain Please review.

Jp-alitec avatar May 31 '24 05:05 Jp-alitec

Hey! I am the guy from the other PR #2798. I have tested both our implementations on runboat and they are practically the same. Our solution looks very similar.

yannoliv avatar Jun 03 '24 14:06 yannoliv

Hey! I am the guy from the other PR #2798. I have tested both our implementations on runboat and they are practically the same. Our solution looks very similar.

@yannoliv try to create branches and then select all companies, there the difference will be visible.

Jp-alitec avatar Jun 03 '24 14:06 Jp-alitec

@legalsylvain @CRogos What is the next step to get this PR merged ?

Jp-alitec avatar Jun 11 '24 05:06 Jp-alitec

@Jp-alitec I'll test it if you rebase to get runboat to build.

StefanRijnhart avatar Aug 30 '24 07:08 StefanRijnhart

@Jp-alitec Again, please rebase to get runboat fixed so it can be tested online.

StefanRijnhart avatar Jan 31 '25 11:01 StefanRijnhart

/ocabot rebase

StefanRijnhart avatar Jan 31 '25 11:01 StefanRijnhart

Congratulations, PR rebased to 17.0.

OCA-git-bot avatar Jan 31 '25 11:01 OCA-git-bot

Please add a future upgrade note in the readme saying Odoo supports this functionality natively in version 18, but only if the user has access to more than nine companies (https://github.com/odoo/odoo/commit/5b597766cd17605).

StefanRijnhart avatar May 06 '25 09:05 StefanRijnhart

@Jp-alitec Hi, can you rebase please. Runboat is not available. Regards

DorianMAG avatar Oct 23 '25 12:10 DorianMAG