Jonathan Woollett-Light
Jonathan Woollett-Light
Considering: > there is no conversion from reference in this version leading to clones in the code I would note that in the conversion via reference in the old approach...
Okay, I'll look into it and commit some changes to sort it.
I can't find where data is now being cloned that it was previously reinterpreted. Notably all the cases of conversion functions I've found as you mention with: >Most conversion functions...
Copying to nalgebra types is no different to cloning (copying is just implicit cloning after all), it will compile to the same. Except implementing a `From` may mislead the user...
It doesn't do 2 clone, for instance see this code: ```rust use std::collections::HashSet; fn main() { let a = vec![String::from("1"),String::from("2"),String::from("3")] // Without using `a` and `b` further it will simply...
If I changed my implementation to implement `std::convert::From` the logic would be the same. Do you disagree with all libraries that clone into `std::convert::From`? One of the reason there is...
> Did you remove the binding manually or re-run rust bindgen? I manually removed some of the assertions within some of the tests which where flagged as UB. > Do...
I can definitely see this may be a personal preference, but I would rather use `.unwrap()` or `?` constantly (as tends to already be the case with many frameworks) than...
1. Boot from `linuxmint-20.3-cinnamon-64bit.iso` (https://linuxmint.com/edition.php?id=292) 2. Establish ethernet or WiFi internet connection. 3. Open terminal 4. `curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh` 5. `source $HOME/.cargo/env` 6. `cargo install...
It wouldn't seem any of these helps resolve the problem, [here is full terminal output covering these](https://pastebin.com/nXhtT7t0) (it is too long to include directly in this comment).