Jonathan Woollett-Light
Jonathan Woollett-Light
So moving from Mint to Ubuntu fixes the issue with `git clone https://github.com/rust-lang/crates.io-index` but the issue with `cargo install rusty-hook` (and other `crates.io` operations) remains.
This seems to also be an issue with Ubuntu. My configuration here: ``` jonathan@jonathan-desk:~$ neofetch .-/+oossssoo+/-. jonathan@jonathan-desk `:+ssssssssssssssssss+:` ---------------------- -+ssssssssssssssssssyyssss+- OS: Ubuntu 22.04 LTS x86_64 .ossssssssssssssssssdMMMNysssso. Kernel: 5.15.0-46-generic /ssssssssssshdmmNNmmyNMMMMhssssss/ Uptime:...
We may be able to avoid having to manually generate these bindings by using https://github.com/rust-vmm/vm-virtio (e.g. specifically https://github.com/rust-vmm/vm-virtio/tree/main/crates/virtio-bindings/src/bindings_v5_0_0), I think the rest of what we manually generate is covered by...
This is an issue we have discussed and decided to address moving forward. We intend to implement a solution like https://github.com/marketplace/actions/continuous-benchmark but adjusted to use BuildKite and some other specifics....
> This PR needs a better motivation on why these new crates are needed. We already use the bitflags crate. We should outline why this is different and what differences...
The current failures in CI are a result of the currently not explicitly allowed license `Unicode-DSF-2016` being present in a transitive dependency. I am looking into this.
> - The breaking up of features for the crate given the size of the PR does seem to be over-engineering the crate quite a bit. If it is a...
> The only major thing that's missing is the unit tests for the procedural macro. I guess that in some parts the code can be modularised even further but it...
Due to outstanding issues with kcov, I have converted this back to a draft.
> * `StructParser` (which could also be renamed to BitFieldParser maybe) which does the initial parsing of the structure and ends up with 3 main parts: > * struct name...