Johannes Kauffmann
Johannes Kauffmann
This allows for using ctest (-V) for running the testsuite, instead of manually calling the test executable. enable_testing() should be in the toplevel CMakeLists.txt, according to the documentation [1]. [1]....
e.g.: ``` ./include/rnnoise.h:51:36: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] RNNOISE_EXPORT int rnnoise_get_size(); ^ void ```
Since 12e27e17deb3102f1f6f08ec19caf5e32becb3f8, it was assumed that the MINGW_HAS_SECURE_API macro was unconditionally defined. This is not always the case, and GCC produces -Wundef warnings when that happens. Fix this, by first...
Originally reported as [QTBUG-106100](https://bugreports.qt.io/browse/QTBUG-106100). glslangValidator.exe crashes under AddressSanitizer on Windows with Visual Studio 17.2.6. Tested with current master (9e78bc8108a13d4d4ed860b2c5547092059ed83e). Fragment shader used: ``` #version 440 layout(location = 0) in vec2...
- Prevent copy of sockaddr_in when calling getAddr() - Formatting and cleanup (newline, spaces etc.) - Group headers according to stdlib, internal, and sort them - Fixed some warnings (Wsign-compare,...
There is no reason to unconditionally build both variants. It increases compile times, and consumers already know whether or not they want a static or shared artifact. Instead, use a...
Running `./build ... --buildroot=~/builddir` results in a `'~'` folder inside of the git clone, which has the `builddir` folder inside it. Just something I noticed while running the script. Maybe...
- Fixed warning about empty string format specifier - Use nullptr instead of 0
Since qtbase 4ecf82795de54fba530ac9c386f3afff2174edbd, use of QT_MODULE was essentially deprecated (12 years ago!). In 6.5 prelease, it was removed completely in qtbase 8446655f24c38d2d52f56d0369182895b6306026. The macro never did anything and is thus...
As a followup from PR #40, I wanted to at least document a few issues I found when building FluidLite on Windows with CMake. Originally, my PR touched some code...