Jim Larson
Jim Larson
We're discussing a generalization of this - allow functions to access the full Activation, not just the supplied variables. This way you could bind `tags` as a variable at runtime...
Just the field name is sufficient - I think we can get what we need from the TypeProvider interface once we have the name.
And this generated markdown can be incorporated into https://github.com/google/cel-spec/blob/master/doc/langdef.md
This might be a good time to incorporate the fixes contemplated in #11223.
@amaurym or @julienrbrt please reenable the automerge. Thanks!
Regarding non-ASCII or ASCII control characters in strings: the more important of the conflicting directives in the spec is the restriction that the rendered text be simple non-control, non-newline ASCII,...
ASCII characters 32-127 are precisely the non-control characters (and newline is a control character). The package documentation suggests that QuoteToASCII produces only the ASCII printable (i.e. non-control) characters, but defers...
FYI, I've coped the @kirbyquerby 's PR and rebased it after the structured screens update.
Reviewers PTAL - addressed all comments.
Added the rationale for fractional second truncation vs sortability. Also confirmed 100% test coverage for the added code (except for the TODO for handling default proto messages).