Jim Larson

Results 20 comments of Jim Larson

Core reviewer - ready for your approval. Changelog update intentionally omitted - we'll have one entry for the whole functionality.

FYI, I'm writing some of these tests in the Agoric fork of cosmos-sdk. I'll share progress here and submit a PR for this repo when I'm done. (I'm out for...

FYI, Agoric is implementing a variant of `PeriodicVestingAccount` that has separate schedules for vesting (subject to clawback) and unlocking (not subject to clawback), with a clawback operation where the funder...

@alexanderbez Sure! The PR is in development, but we're trying to get it merged into our fork this week-ish. See https://github.com/agoric-labs/cosmos-sdk/pull/155 Don't be dissuaded by the "draft" status - we're...

In the agoric-labs#155 PR, I addressed the issue of knowing the funder by creating a new vesting account type (a variant of `PeriodicVestingAccount`) with the funder address as an explicit...

It should be optional - there are legal arrangement that require vesting but don't give the grantor the right to claw back. There are two other features that make sense:...

Yes, my mistake, there are arrangements that require lockup (the encumbrance formerly known as vesting), but do not allow clawback. My point was that clawback shouldn't automatically be enabled for...

Sorry for the late reply - I was out for the holidays, then came down with a cold upon my return. This is a very nice mechanism and I think...

On the other hand, changing multi-send into iterated single-sends would mean different events were generated, which might break other things. Maybe event generation could be deferred and aggregated in a...

Looking at the code more closely, it looks like the best approach would be to lift the event code out of `subUnlockedCoins()` and `addCoins()` into their callers - which also...