Jan Weldert
Jan Weldert
A current hack is to use the detectors class to define different "detectors", one per PID bin (to use the example from before), and choose different energy and coszen binning...
I guess Tom might use this branch. We should at least ask him if there are any functionalities missing in main. Maybe adding one or two things is sufficient and...
You'r right, the code in L900 and L908 should be similar to L739
Option 2 has been implemented.
Right, #108 has the same idea. The others are mainly talking about making PID a binning dimension, which was already done. Might be possible to close some of them.
Both ask for the option to have variable binning options, so we can close this one in favor of #108
Use #108 instead
We can delete pisa_tests/test_Detectors_class.py, it just duplicates code from https://github.com/icecube/pisa/blob/master/pisa/core/detectors.py#L346
But in the numpy version you have to do the interpolation again every time you want to evaluate it.
Ah right, good point. I will add the check for chi2 metrics. I haven't compared it to any frequentist analysis so far, mainly because it is pretty slow.