pisa icon indicating copy to clipboard operation
pisa copied to clipboard

Variable binning options

Open JanWeldert opened this issue 1 year ago • 2 comments

When defining a multidimensional binning we combine one dimensional binnings in a homogeneous grid. So if we for example bin our data in energy, coszen, and PID, we have to use the same energy and coszen binning for all PID bins. It was requested multiple times now to make this more flexible. A current hack is to use the detectors class to define different "detectors", one per PID bin (to use the example from before), and choose different energy and coszen binning for each of them. Note that for each detector you have to remove all events that don't fall in the respective PID bin.

JanWeldert avatar Aug 15 '24 15:08 JanWeldert

Potential duplicate/overlap with #108, #158, #248, and #284.

LeanderFischer avatar Aug 15 '24 15:08 LeanderFischer

Right, #108 has the same idea. The others are mainly talking about making PID a binning dimension, which was already done. Might be possible to close some of them.

JanWeldert avatar Aug 16 '24 06:08 JanWeldert

@JanWeldert Should we add your comment on the possibility of using the Detectors class to #108 (which already contains a collection of implementation ideas) and then close this as duplicate? Or is the idea to implement a new service as per #108 too specific?

thehrh avatar Sep 10 '24 14:09 thehrh

Both ask for the option to have variable binning options, so we can close this one in favor of #108

JanWeldert avatar Sep 11 '24 08:09 JanWeldert

Use #108 instead

JanWeldert avatar Sep 17 '24 09:09 JanWeldert