James Marino comments

Results 8 comments of


                                            James Marino

unable to import package

Having the same problem > Unable to resolve module NativeModules

feat: added arm v8 to docker build and push

Thanks for the review @djfarrelly - what error were you getting when trying to run the build locally? I'm not sure there is anything I needed to do in particular...

Memory leak when adding a bookmark link in post editor

> @JamesMarino do you see similar memory spikes when uploading an image into the editor? @kevinansfield I uploaded an image to the editor of size 5MB, did this about 6...

Memory leak when adding a bookmark link in post editor

I was digging into profiling the [`oembedService.fetchOembedDataFromUrl`](https://github.com/TryGhost/Ghost/blob/v5.94.0/ghost/oembed-service/lib/OEmbedService.js#L424) method and noticed an [external library](https://github.com/microlinkhq/metascraper) for the link scraping and meta tag parsing [here](https://github.com/TryGhost/Ghost/blob/v5.94.0/ghost/oembed-service/lib/OEmbedService.js#L276). It seems to be building some sort of...

Multiple users signing up with name "adwdasddwa"

@sam-lord I've noticed with the flag enabled this seems to block all email signups. It seems that `req.body.integrityToken` is not being passed in at all by the front end. On...

Multiple users signing up with name "adwdasddwa"

@9larsons no problem - any chance this release will be pushed to https://hub.docker.com/_/ghost anytime soon? Thanks.

Cache control directives stale-while-revalidate and stale-if-error for frontend do not get sent even when Ghost config is set

No worries @ErisDS - thanks for the feedback. I thought it would be a good idea to bring the caching config inline with the [Cache-Control](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control) HTTP spec which seems to...

Cache control directives stale-while-revalidate and stale-if-error for frontend do not get sent even when Ghost config is set

Hi @ErisDS - just wondering if there was any thoughts on getting [this PR](https://github.com/TryGhost/Ghost/pull/21887/files) in and if everything was fine internally for this to be merged? Thanks!