maildev icon indicating copy to clipboard operation
maildev copied to clipboard

feat: added arm v8 to docker build and push

Open JamesMarino opened this issue 3 years ago • 2 comments

Added ARM v8 Docker architecture to both build and push scripts.

This has been tested using a personal repo.

JamesMarino avatar Dec 27 '22 04:12 JamesMarino

Thanks for the review @djfarrelly - what error were you getting when trying to run the build locally? I'm not sure there is anything I needed to do in particular to support linux/arm/v8 on my Mac. I'm able to run the command on Docker Desktop 4.15.0, Engine 20.10.21 and BuildX 0.9.1 and on a MacBook Pro with Intel and Apple Silicon chips.

Addressing the issue higher, how would you feel about running a GitHub Action that would automatically Docker build and push to the maildev/maildev Docker Hub when run on master? This would take out the problem for issues arising when building and pushing multiple platforms on individual devices locally.

JamesMarino avatar Jan 07 '23 04:01 JamesMarino

Hi @JamesMarino, my Docker for mac gives me these options for buildx:

docker run --privileged --rm tonistiigi/binfmt --install all
{
  "supported": [
    "linux/arm64",
    "linux/amd64",
    "linux/riscv64",
    "linux/ppc64le",
    "linux/s390x",
    "linux/386",
    "linux/mips64le",
    "linux/mips64",
    "linux/arm/v7",
    "linux/arm/v6"
  ],
  "emulators": [
    "qemu-arm",
    "qemu-i386",
    "qemu-mips64",
    "qemu-mips64el",
    "qemu-ppc64le",
    "qemu-riscv64",
    "qemu-s390x",
    "qemu-x86_64"
  ]
}

I would be up for automating pushing to Docker hub, the only challenges are with QA on the image (less needed if there are automated integration tests with the container image. I think the image release can be run on Github actions, but should still be triggered for a particular release tag then just push to "latest" (I've also seen that having version tags on Docker images are best if a regression sneaks into master it might break people's setup). Would you be interested in writing that Github action for this repo?

djfarrelly avatar Jan 16 '23 23:01 djfarrelly