Jack Green

Results 66 comments of Jack Green

I've tried the 1.7 Eclipse plugin from #331 but this issue is still present.

This is still a problem in Eclipse plugin version `1.11.0`.

Re-occured on [Hazelcast-master-ZingJDK21](https://jenkins.hazelcast.com/job/Hazelcast-master-ZingJDK21/10/): - `com.hazelcast.internal.server.tcp.TcpServerContextTest.testGetOutboundPorts_returnsEmptyCollectionByDefault`: ``` java.lang.NullPointerException: Cannot invoke "com.hazelcast.config.Config.getAdvancedNetworkConfig()" because "config" is null at com.hazelcast.internal.server.tcp.TcpServerContext.initRestApiConfig(TcpServerContext.java:81) at com.hazelcast.internal.server.tcp.TcpServerContext.(TcpServerContext.java:76) at com.hazelcast.internal.server.tcp.TcpServerContextTest.setUp(TcpServerContextTest.java:57) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at com.hazelcast.test.AbstractHazelcastClassRunner$ThreadDumpAwareRunAfters.evaluate(AbstractHazelcastClassRunner.java:365) at com.hazelcast.test.DumpBuildInfoOnFailureRule$1.evaluate(DumpBuildInfoOnFailureRule.java:37) at com.hazelcast.test.jitter.JitterRule$1.evaluate(JitterRule.java:104) at com.hazelcast.test.metrics.MetricsRule$1.evaluate(MetricsRule.java:63)...

@dr-divago thanks for your contribution! It's great you've addressed these issues - had you considered amending the test referenced in https://github.com/hazelcast/hazelcast/issues/26193 to see if further examples could be caught going...

> @JackPGreen Do you mean to check all the references of JUnit5 in the codebase? Or fixing `com.hazelcast.NoMixedJUnitAnnotationsInOurTestSourcesTest.noJUnitMixing()?` I thought fixing the `noJUnitMixing` test to find other scenarios and ensure...

The job `Hazelcast-mono-OS-pr-builder` of your PR failed. (Hazelcast internal details: [build log](https://s3.console.aws.amazon.com/s3/buckets/j-artifacts/Hazelcast-mono-OS-pr-builder/3132/Hazelcast-mono-OS-pr-builder-3132.zip), [artifacts](https://s3.console.aws.amazon.com/s3/buckets/j-artifacts/Hazelcast-mono-OS-pr-builder/3132/Hazelcast-mono-OS-pr-builder-3132.zip)). Through arcane magic we have determined that the following fragments from the build log may contain information...

> Hi @JackPGreen I updated the PR. How to access the build log? It's an internal tool unfortunately, but all tests have passed :)

> Hi @JackPGreen is something missing in the PR? No, just waiting for a second reviewer.

> @JackPGreen why the PR was closed? It’s open again now, apologies :)

Hi - thanks for your contribution. Are you able to add any test cases for where this problem occurs? Just wondering if a `try` / `catch` is the best solution...