google-java-format icon indicating copy to clipboard operation
google-java-format copied to clipboard

//$NON-NLS-x$ notation broken in Eclipse formatter 1.6

Open JackPGreen opened this issue 6 years ago • 3 comments

Take the simple class:

public class test {
  public static void main(final String[] args) {
    String myString = "someString"; //$NON-NLS-1$
  }
}

Using "google-java-format-eclipse-plugin_1.6.0.jar", when formatted it converts: //$NON-NLS-1$ To: // $NON-NLS-1$

This is supposed to be fixed in issue #221, but doesn't appear to be...?

Am I missing something?

JackPGreen avatar Apr 05 '19 10:04 JackPGreen

I've tried the 1.7 Eclipse plugin from #331 but this issue is still present.

JackPGreen avatar Apr 05 '19 11:04 JackPGreen

I think it was only fixed for cases where the //$NON-NLS-1$ comment appears on its own line.

cushon avatar Dec 19 '19 22:12 cushon

This is still a problem in Eclipse plugin version 1.11.0.

JackPGreen avatar Nov 09 '21 15:11 JackPGreen