Hesketh2
Hesketh2
There are issues I need help with the current revision here https://liquipedia.net/teamfortress/User:Hesketh2  - Matches always ended up having the left side being the winner, this include even if per...
The most recent revision seems to fix the issue I have, I had the **placementSortFunction** as local function in the module but I made the call going to the commons...
wanted to revisit on this one, I'm still need help on how to solve the unexpected winner issue with the setplacement thing
> > wanted to revisit on this one, I'm still need help on how to solve the unexpected winner issue with the setplacement thing > > what "unexpected winner" issue?...
Revisiting this I believe all the requested changes are there, not sure if I missed any
I assume this error will go away after 4634 merged 
> lgtm if tested > > did you compare old match1 data to new match1 data? How to test it again? I recall theres one when wildrift was worked on...
I also rename the **MatchGroupInput** to **MatchGroupInputUtil** for more consistency vs other wikis too
pinging if theres anything I need to fix more
Pasting over onto |dev=1 - https://liquipedia.net/clashroyale/index.php?title=User:Hesketh2/test&action=edit&redlink=1  Seems working with the submatch variation but not as for Solo/Duos with cards