Liquipedia
feat(match2): create team fortress support
Summary
Match2 for Team Fortress wiki, they are one of wikis that hasnt got one but also pretty similar to existing setups we have.
Base
- The first revision is a paste from World of Tanks (which Tanks itself is then a cleaner/updated version based on COD)
- a Match of TF behaves similar to those, Have Maps and Scores
Custom
- Due to Team Fortress has quite a lot of custom links that needs to be added back, there are more than usual here
- logstf and logstfgold are suggested to be added as Per Map instead of a single link. Similar to stats in CS Match2, because of this both logstf does get stored in Extradatas.
- Vetos/MVP may be removed later, I'm still waiting response from the editors if they want it
How did you test this change?
LIVE on Several pages : https://liquipedia.net/teamfortress/ETF2L/Season_31/Highlander/Premiership/Preseason_Playoffs
Sidenote
Because there are the {{match}} vs {{match/old}} thing that needs to be converted, the Copypaste Generator is not included here, will make a separate PR when the conversion for that is done
There are issues I need help with the current revision here https://liquipedia.net/teamfortress/User:Hesketh2
- Matches always ended up having the left side being the winner, this include even if per Map sets the winner to 2, the matchlist sets left side team as winner
- for Maps that used
|finished=trueover winner=X, regardless of score the leftside also always won
had no idea which part cause this
The most recent revision seems to fix the issue I have, I had the placementSortFunction as local function in the module but I made the call going to the commons MatchGroup/Input which doesnt seem to have it
idk if this is the actual fix it was too simple for me to assume I did it correctly but at least right now its fixed. Now the setPlacement thing is left because I cant delete anything in that function locally at all otherwise the match just throws error
I could not find other wikis that had converted setPlacement to commons as well that I could copy over
wanted to revisit on this one, I'm still need help on how to solve the unexpected winner issue with the setplacement thing
wanted to revisit on this one, I'm still need help on how to solve the unexpected winner issue with the setplacement thing
what "unexpected winner" issue?
wanted to revisit on this one, I'm still need help on how to solve the unexpected winner issue with the setplacement thing
what "unexpected winner" issue?
So right now if I removed the SetPlacement function thats locally in the process module (in hopes of using the function from commons instead) https://liquipedia.net/teamfortress/index.php?title=Module%3AMatchGroup%2FInput%2FCustom%2Fdev&type=revision&diff=127718&oldid=127717
The unexpected winner error would show
setPlacement do get called in three other places, my assumption is the input in the parentheses needs to be changed?
https://liquipedia.net/teamfortress/index.php?title=Module%3AMatchGroup%2FInput%2FCustom%2Fdev&type=revision&diff=127721&oldid=127718
Revisiting this I believe all the requested changes are there, not sure if I missed any
lgtm if tested
did you compare old match1 data to new match1 data?
How to test it again? I recall theres one when wildrift was worked on but I cant find the module for the test it
but from comparing a match of both bracket version on first glance it looks normal to me: https://liquipedia.net/teamfortress/Special:LiquipediaDB/User:Hesketh2#match
lgtm if tested did you compare old match1 data to new match1 data?
How to test it again? I recall theres one when wildrift was worked on but I cant find the module for the test it
but from comparing a match of both bracket version on first glance it looks normal to me: https://liquipedia.net/teamfortress/Special:LiquipediaDB/User:Hesketh2#match
if the data is identical that means it is fine :)
I also rename the MatchGroupInput to MatchGroupInputUtil for more consistency vs other wikis too