Hari Srinivasan

Results 28 comments of Hari Srinivasan

@thiswillbeyourgithub this feature has been created, and will be shipped out with ver 2.19.

> I would be happy to work on this issue if no one else is. Hey! the fix for this is quite simple, issue is the exact phrasing and deciding...

> I personally think a visual approach would be better, something like this (maybe with icons instead of text): I disagree, visual approaches often create more confusion and aren't friendly...

@mikehardy I tried to verify page size with: ```yml - name: Verify Page Size if: matrix.target == 'google_apis_ps16k' run: | PAGE_SIZE=$(adb shell getconf PAGE_SIZE) echo "Page size: $PAGE_SIZE" if [...

> @Haz3-jolt Would you be OK with marking this as a draft until CI passes? It's coming up a lot in my notification queue, and turns out to be 'no...

I have some extra free time this week, I'll see if I can get this in. Should not be too hard,

We need to test on 16kb page size emulators, but the runners we use [android-emulator-runner](https://github.com/ReactiveCircus/android-emulator-runner), which doesn't yet have a release with the PR adding in support for 16kb emulators.

> Well, that's disappointing. `@actions/core not found` !? so CI still failed when it tried to run that action based on the commit hash, which is unexpected. So this is...

> I don't have time to do a code review now, but I really like the look of it! Thanks! But david gave some feedback and it was decided that...