CI test for 16kb and non-16kb page alignment
Purpose / Description
Updates GitHub workflow matrix to extend to 16kb page alignment.
Fixes
- Fixes #16917
Approach
- Attempts to verify the APK with 16KB page alignment
- First tries with build-tools v35.0.0, then falls back to v34.0.0 if needed
- Provides clear success/failure messages
How Has This Been Tested?
Passes CI on fork
Learning (optional, can help others)
Refered to 16KB page alignment docs
Checklist
Please, go through these checks before submitting the PR.
- [x] You have a descriptive commit message with a short title (first line, max 50 chars).
- [x] You have commented your code, particularly in hard-to-understand areas
- [x] You have performed a self-review of your own code
- [ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
- [ ] UI Changes: You have tested your change using the Google Accessibility Scanner
@mikehardy I tried to verify page size with:
- name: Verify Page Size
if: matrix.target == 'google_apis_ps16k'
run: |
PAGE_SIZE=$(adb shell getconf PAGE_SIZE)
echo "Page size: $PAGE_SIZE"
if [ "$PAGE_SIZE" != "16384" ]; then
echo "Error: Expected page size of 16384, got $PAGE_SIZE"
exit 1
fi
But when I noticed it wasn't running in the tests, I realised we can't run adb shell getconf PAGE_SIZE, without an emulator. Is it okay to not include it? I've tried adding it to the Emulator script in here. But It wasn't working.
Is there some other way to test it?
@Haz3-jolt Would you be OK with marking this as a draft until CI passes? It's coming up a lot in my notification queue, and turns out to be 'no action needed yet'
PS: Be sure GSoC is a priority
PPS: You're doing great! Please take these messages with as many genuine smiley faces as necessary 😄
@Haz3-jolt Would you be OK with marking this as a draft until CI passes? It's coming up a lot in my notification queue, and turns out to be 'no action needed yet'
PS: Be sure GSoC is a priority
PPS: You're doing great! Please take these messages with as many genuine smiley faces as necessary 😄
Yeah totally get it, the kinda messy part about this PR is no local testing at all, so gotta push to check if CI Passes 😄