David

Results 6 comments of David

> Note that users can already do all of this via [processors](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/docs/trace/extending-the-sdk/README.md#processor). I'm not sure what is proposed here can be achieved through processors. Whilst the end time of an...

Hey thanks so much for taking the time to review. > One thing I'm slightly concerned about, is that Npgsql will probably support other activities, and not just command execution...

@roji Sorry for the ping back on this, I know it took me a little while to respond to the previous comment, but I think this should be good to...

@roji Sorry for another ping, just thinking it is likely less than a month to the v7 release - is this likely to get in?

If you want to avoid reflection... The solution we ended up using for now, until the library gives us more flexibility, is actually upstream of the app in the tracing...

That looks really similar to what I was proposing in https://github.com/npgsql/npgsql/pull/4284: ```csharp .AddNpgsql(options => { options.EnrichCommandExecution = (activity, eventName, rawNpgsqlCommand) => { if (rawNpgsqlCommand is not NpgsqlCommand cmd) return; //...