Harvey Delaney

Results 7 comments of Harvey Delaney

Hey @lahma and @Varorbc, I would love for it to be brought in! A simple link to the blog post as a comment above the `RetryAttribute ` class and/or in...

Try adding `react-redux` `redux` `redux-form` to `peerDependencies` so that they're not bundled. Then make sure the consuming projects has these `peerDependencies`.

Issue was resolved in: https://github.com/HarveyD/react-component-library/issues/14 Please update the branch and try again. In regards to your second point, the best we can do is: ``` import TestComponent from 'react-component-library/build/TestComponent'; ```...

You have to add an entrypoint to the new component in `rollup-config.js`: ``` input: ["src/index.ts", "src/TestComponent/index.ts"], ```

I've updated the branch. You'll need to rebase on it, or look at what I've changed (removed `rollup-plugin-postcss`) and make those changes :)

Yeah it seems like code splitting and bundling 3rd party dependencies don't play nicely together. The plugin you mentioned checks all the dependencies and prevents them from being bundled (and...

I don't want to include code splitting in the main branch due to the issues that exist around with code splitting and bundling 3rd party dependencies. If I can sort...