react-component-library icon indicating copy to clipboard operation
react-component-library copied to clipboard

[Feature] Enable code splitting in main branch

Open mnlbox opened this issue 5 years ago • 1 comments

I think it's a good idea to enable code splitting and esm export together in the main branch. Then we can have esm and also split cjs version together. And use our component in both ways like this for es import:

import { Button } from 'component-library'

and like this, if we have default export:

import Button from 'component-library/src/Button'

or like this, of we have named export:

import { Button } from 'component-library/src/Button'

@HarveyD What's your idea?

mnlbox avatar Jul 07 '20 08:07 mnlbox

I don't want to include code splitting in the main branch due to the issues that exist around with code splitting and bundling 3rd party dependencies. If I can sort this out, I'd consider it :).

Also, I don't believe you can have cjs and esm code split outputs in the same directory. This increases the length of our imports which I'd rather avoid.

HarveyD avatar Jul 11 '20 05:07 HarveyD