Giovanni Canali
Giovanni Canali
> I would make this PR more general to upload new optimisers for PINNs. Torch is quite behind in the update from the PINN community. What do you think @GiovanniCanali...
> Why is this happening? We should not test training for problems; it should work right out of the box since we have modular tests Device error + wrong modifications...
The issue was edited, no further references to training tests for problems in `problem.zoo`
Hi @dario-coscia, Thank you for looking into this issue further. The linked issue has been open since January 2023 and doesn’t seem to be actively maintained. I’m a bit perplexed,...
@dario-coscia Since #626 was a temporary fix, I would not mark the issue as closed.
> To me looks good the structure, I am only wondering if we should merge it as it is or making it draft, update all files where we want type...
> Maybe also related to #551 ? @GiovanniCanali what do you think? Yes, definitively!
Hi, I am closing this issue due to inactivity. If there are any further questions, I will reopen it.
> Thank you @dario-coscia for this PR. > > I agree on the proposed changes, but I do not like how you make the user aware of manual optimization. In...
> > Thank you @dario-coscia for this PR. > > I agree on the proposed changes, but I do not like how you make the user aware of manual optimization....