Bug in Helmholtz and Advection problems from zoo

[GiovanniCanali]

Describe the bug The classes HelmholtzProblem and Advection contain unintended self references, which result in unexpected behavior during execution.

Details

• In HelmholtzProblem, the method signature includes an extra self argument in forcing_term, which causes a mismatch when the method is called:

def forcing_term(self, input_):

This should likely omit self.

• In Advection, the expression self.c is used within the equation method, but this reference introduces unintended behavior (unwanted changes of the attribute self.c)

[dario-coscia]

Why is this happening? We should not test training for problems; it should work right out of the box since we have modular tests

[GiovanniCanali]

Why is this happening? We should not test training for problems; it should work right out of the box since we have modular tests

Device error + wrong modifications to a class attribute at runtime. Not spotted if not during training.

[GiovanniCanali]

The issue was edited, no further references to training tests for problems in problem.zoo